Draft
Conversation
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1551 +/- ##
=======================================
Coverage 92.83% 92.83%
=======================================
Files 152 152
Lines 8614 8614
=======================================
Hits 7997 7997
Misses 617 617
🚀 New features to boost your workflow:
|
rtuck99
changed the title
rtuck99
force-pushed
the
1354_scintillator_safe_move
branch
from
1044d20 to
ec0b1b8
Compare
…lan instead of directly calling the scintillator set
rtuck99
force-pushed
the
1354_scintillator_safe_move
branch
from
ec0b1b8 to
3dd7c3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1354
Link to dodal PR (if required):
Mx bluesky 1354 scintillator safe move dodal#1819
UDC Default state will no longer fail if the scintillator requires moving, instead the move will cause the aperture scatterguard to be moved out of the way first
The beamstop must be in one of the recognised positions in order to move the scintillator.
Instructions to reviewer on how to test:
Checks for reviewer